Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the paypal payment method option out of pre-release #4865

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Get the paypal payment method option out of pre-release #4865

merged 1 commit into from
Jan 24, 2023

Conversation

elia
Copy link
Member

@elia elia commented Jan 23, 2023 •
edited
Loading

Summary

v1.0 is being released right now after it had sufficient time to gather and fix trivial bugs.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@elia
Get the paypal payment method option out of pre-release
1c3b56c 
v1.0 is being released right now after it had sufficient time to
gather and fix trivial bugs.
@elia elia self-assigned this Jan 23, 2023
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Merging #4865 (1c3b56c) into master (36340a8) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #4865   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         578      578           
  Lines       14671    14671           
=======================================
  Hits        12652    12652           
  Misses       2019     2019
Impacted Files Coverage Δ
...dus/install/app_templates/payment_method/paypal.rb 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review January 23, 2023 10:33
@elia elia requested a review from a team as a code owner January 23, 2023 10:33
waiting-for-dev
waiting-for-dev approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Jan 23, 2023
@waiting-for-dev waiting-for-dev merged commit b67bed9 into master Jan 24, 2023
@waiting-for-dev waiting-for-dev deleted the elia/paypal-1-0 branch January 24, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees

@elia elia

Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elia @waiting-for-dev @kennyadsl @jarednorman