Add a better description for the api key to Stoplight #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_api
vassalloandrea
force-pushed
the
av/enhance-stoplight-api-key-description
branch
2 times, most recently
from
e479ebe to
bed9353
Compare
vassalloandrea
force-pushed
the
av/enhance-stoplight-api-key-description
branch
from
bed9353 to
647b60d
Compare
|
Thanks, @vassalloandrea 🙇 Left a suggestion |
vassalloandrea
requested review from
waiting-for-dev
and removed request for
kennyadsl
vassalloandrea
force-pushed
the
av/enhance-stoplight-api-key-description
branch
from
647b60d to
9870655
Compare
vassalloandrea
requested review from
kennyadsl and
waiting-for-dev
and removed request for
waiting-for-dev and
kennyadsl
waiting-for-dev
approved these changes
Jan 20, 2023
|
@vassalloandrea I think we are ready to merge, and the CI has finally started. Can you please rebase? 🙏 |
Some endpoints that are not related to the users can be used without the api key changing the Solidus configuration. Add the instruction to do it.
vassalloandrea
force-pushed
the
av/enhance-stoplight-api-key-description
branch
from
9870655 to
4a689de
Compare
Codecov Report
@@ Coverage Diff @@
## master #4847 +/- ##
=======================================
Coverage 86.23% 86.23%
=======================================
Files 578 578
Lines 14674 14674
=======================================
Hits 12654 12654
Misses 2020 2020 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kennyadsl
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some endpoints that are not related to the users can be used without the API key changing the Solidus configuration.
Add the instruction to do it.
Thank you for the help @Jackwitwicky!
Screenshots
Stoplight security schema
Authentication.md
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have added automated tests to cover my changes.- [ ] I have opened a PR to update the guides.