Remove Ruby v2.5 support #4845
Merged
Remove Ruby v2.5 support #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:repository
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_ruby_v2.5_support
branch
from
71ff2f3 to
e3090f7
Compare
github-actions
bot
removed
the
changelog:repository
Ruby v2.5 is EOL since 05 Apr 2021 [1]. Our new release policy [2] makes it clear that we don't support Ruby versions that are no longer maintained. [1] - https://www.ruby-lang.org/en/downloads/branches/ [2] - https://solidus.io/release_policy/
The new syntax was introduced back on Ruby v2.6 [1] [1] - https://ruby-doc.org/core-2.6/Range.html#class-Range-label-Endless+Ranges
`Object#yield_self` is available from Ruby 2.6 [1] [1] - https://ruby-doc.org/core-2.6/Object.html#method-i-yield_self
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_ruby_v2.5_support
branch
from
e3090f7 to
1f11c28
Compare
elia
approved these changes
Jan 10, 2023
adammathys
approved these changes
Jan 10, 2023
kennyadsl
approved these changes
Jan 11, 2023
| @@ -18,7 +18,7 @@ def build_gem_lines(conservative_versioning) | |||
| requirement = if is_local | |||
| ", path: \"#{d.source.path}\"" | |||
| elsif is_git | |||
| ", git: \"#{d.git}\"".yield_self { |g| d.ref ? g + ", ref: \"#{d.ref}\"" : g } | |||
| ", git: \"#{d.git}\"".then { |g| d.ref ? g + ", ref: \"#{d.ref}\"" : g } | |||
|
|
I did that just now to be able to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby v2.5 is EOL since 05 Apr 2021.
Our new release policy makes it clear that we don't support Ruby versions that are no longer maintained.
We also make a basic sanitization check in our code base to update to newer standards:
Closes #4840
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the README to account for my changes.