Improve Spree::Order::NumberGenerator speed #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov Report
@@ Coverage Diff @@
## master #4722 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 577 577
Lines 14640 14643 +3
=======================================
+ Hits 12608 12612 +4
+ Misses 2032 2031 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
waiting-for-dev
approved these changes
Nov 17, 2022
When generating a number, if it already exists, the length of numbers will be increased if over half of the possible options are already taken. This query is very expensive when having millions of records. Upon multiple number collisions, this SQL becomes a bottleneck. Co-authored-by: Sung <sung@meundies.com>
RyanofWoods
force-pushed
the
ryanofwoods/improve-order-number-generator-speed
branch
from
758583e to
4cce19a
Compare
|
No problem @waiting-for-dev , thanks for MeUndies for discovering this ❤️ I just pushed again as I added some specs. |
forkata
approved these changes
Nov 17, 2022
jarednorman
approved these changes
Nov 18, 2022
I don't understand, what's your point? @jarednorman 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When generating a number, if it already exists, the length of numbers will be increased if over half of the possible options are already taken. Calculating the count of orders is very expensive when having millions of records. Upon multiple number collisions, this SQL becomes a bottleneck.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have attached screenshots to demo visual changes.- [ ] I have opened a PR to update the guides.- [ ] I have updated the README to account for my changes.