Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key in the locale file #4512

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

waiting-for-dev
Copy link
Contributor

Summary

NO evaluates to false without quotes

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • [ ] I have added automated tests to cover my changes.
  • [ ] I have attached screenshots to demo visual changes.
  • [ ] I have opened a PR to update the guides.
  • [ ] I have updated the readme to account for my changes.

NO evaluates to `false` without quotes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. LOL. Thanks Marc

@waiting-for-dev
Copy link
Contributor Author

TIL. LOL. Thanks Marc

Hehe same here 🙂

Merging to fix CI

@waiting-for-dev waiting-for-dev merged commit c7f5040 into solidusio:master Aug 17, 2022
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/fix_key branch August 17, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants