Fail with raise when the storage adapter is not supported
#4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `abort` is raised on a CI test, it's skipped, but it's not counted as a failure, giving an obscure error result on the corresponding job. See f1f9ca1 for an example.
waiting-for-dev
force-pushed
the
waiting-for-dev/fail_smart
branch
from
e9242ca to
012db5c
Compare
jarednorman
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
abortis raised on a CI test, it's skipped, but it's not countedas a failure, giving an obscure error result on the corresponding job.
See f1f9ca1 for an example.