Skip failing test because of unsupported feature on Rails < 6.1 #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_ci
branch
from
8824964 to
564f7bd
Compare
`ActiveStorageAdapter` is only supposed to work on Rails versions greater than 6.1. CI was silently failing on Rails 5.2 & 6.0 because of calling `abort` on our code [1]. 1 - https://github.com/solidusio/solidus/blob/aa77140e8c5b07ab597126ba76524a3931bbb449/core/app/models/concerns/spree/active_storage_adapter.rb#L13
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_ci
branch
from
564f7bd to
f1f9ca1
Compare
waiting-for-dev
changed the title
kennyadsl
approved these changes
Jun 21, 2022
|
I will merge it even if there's only a single approval, as it's a fix for the CI and blocking all other open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveStorageAdapteris only supposed to work on Rails versionsgreater than 6.1.
CI was silently failing on Rails 5.2 because of calling
aborton ourcode.
I'll create a follow-up PR using
raiseinstead ofabort.