Allow user stock locations to be deleted #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to roles, not stock locations.
This provides spec parity for other HABTM relationships.
This will allow for removing all user-stock location relations. Without this, once a user has an associated stock location, they must ALWAYS have at least one.
This mirrors the user roles specs, and tests the fixed behavior around user stock locations.
jarednorman
approved these changes
May 30, 2022
|
Thanks, @rmparr! Would you like to create backport PRs for supported Solidus versions? (v2.11, v3.0 & v3.1). |
This was referenced Jun 1, 2022
|
@waiting-for-dev Absolutely! |
|
Thanks, @rmparr! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if using
Spree::UserStockLocationassociations, once a user has an associated stock location, it is impossible to remove all associated stock locations. This is because the template is missing a hidden field foruser[:stock_location_ids].This PR remedies the problem by mirroring the conventions used for the user's roles. It also adds coverage around the expected behavior in the controller, which was missing.
Checklist: