Add missing sprockets-rails dependency #4382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7 doesn't have sprockets-rails as a dependency anymore [1].
However, it's a dependency on solidus_core [2].
We hadn't caught it because our test suite depends transitively on it
through sassc-rails [3] in solidus_backend [4] & solidus_frontend [5].
However, we had an incompatibility when using standalone solidus_core
(like in the dummy app for extensions) with Rails 7.
[1] - https://guides.rubyonrails.org/7_0_release_notes.html#railties-notable-changes
[2]
solidus/core/lib/spree/core.rb
Line 10 in 35d43a1
[3] - https://github.com/sass/sassc-rails/blob/8d0462d54b5b5dd84cb1df31823c3afaebb64534/sassc-rails.gemspec#L31
[4]
solidus/backend/solidus_backend.gemspec
Line 35 in 455754b
[5]
solidus/frontend/solidus_frontend.gemspec
Line 34 in 455754b