Support for Ruby 3.1 #4366
Merged
Support for Ruby 3.1 #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite adapter fails to provide a unique index for the convoluted chain of ActiveRecord persistence calls that happen on https://github.com/solidusio/solidus/blob/8b03161a1894a7d10c8d95f62c016da55027d2b0/core/app/models/spree/stock/simple_coordinator.rb#L83. ``` SQLite3::ConstraintException: UNIQUE constraint failed: spree_shipping_rates.shipment_id, spree_shipping_rates.shipping_method_id ``` That's not a problem on production databases (MySQL & PostgreSQL), but at least we mark the tests as failing locally. [skip ci]
The new Psych version required by Ruby 3.1 no longer allows the loading of arbitrary classes into YAML by default. We switch to `#safe_load` and enable the class we're currently using. See: ruby/psych@cb50aa8 ruby/psych@1764942 [skip ci]
kennyadsl
approved these changes
May 3, 2022
spaghetticode
approved these changes
May 4, 2022
Naokimi
added a commit
to solidusio/solidus_bolt
that referenced
this pull request
May 12, 2022
This currently won't display correctly in Ruby 2.5 - 2.7 due to an error caused by solidusio/solidus#4366
Naokimi
added a commit
to solidusio/solidus_bolt
that referenced
this pull request
May 13, 2022
This currently won't display correctly in Ruby 2.5 - 2.7 due to an error caused by solidusio/solidus#4366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4359, with
masteras the base branch. We closed that one by mistake. @kennyadsl, @jarednorman, you already had approved that one.