Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance refund admin UI #4348

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Enhance refund admin UI #4348

merged 2 commits into from
Apr 22, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 20, 2022

Description

This makes the refund form look better in non-english locales.

  • Use proper localization of amounts
  • Use actions translations in buttons and links
  • Fix refund icon class
  • Add a prompt to refund reason select

New Refund before

New Refund - Payment 1 - Payments - #R406003024 - Orders 2022-04-20 22-42-06

New Refund after

New Refund - Payment 1 - Payments - #R406003024 - Orders 2022-04-20 22-39-17

Payments before

Payments - #R406003024 - Orders 2022-04-20 22-41-44

Payments after

Payments - #R406003024 - Orders 2022-04-20 22-39-34

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have attached screenshots to this PR for visual changes

jarednorman
jarednorman approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like all good changes to me. Thanks @tvdeyen!

@tvdeyen tvdeyen closed this Apr 21, 2022
@tvdeyen tvdeyen reopened this Apr 21, 2022
This was referenced Apr 21, 2022
Merged
Merged
Merged
@tvdeyen
Enhance refund admin UI
aec59f1 
This makes the refund form look better in non-english locales.

- Use proper localization of amounts
- Use actions translations in buttons and links
- Fix refund icon class
- Add a prompt to refund reason select
@tvdeyen
Fix number_with_currency field CSS issues
2493028 
Error state has not been applied because of unnecessarily deep Sass nesting.
Also we must not allow to flex wrap. We always want this widget to be inline, even if a field_with_error span is in the DOM.
@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 22, 2022

Added a fix for error state of the number_with_currency input

Before

Monosnap 2022-04-22 09-40-53

After

Neue Gutschrift - Bezahlung 3 - Bezahlungen - R123456789 - Bestellungen 2022-04-22 09-41-03

@tvdeyen tvdeyen added UI changelog:solidus_backend Changes to the solidus_backend gem labels Apr 22, 2022
kennyadsl
kennyadsl approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas!

@tvdeyen tvdeyen merged commit 8b03161 into solidusio:master Apr 22, 2022
@tvdeyen tvdeyen deleted the fix-refund-form branch April 22, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvdeyen @kennyadsl @jarednorman