Fix flaky spec for Spree::ShippingMethod#available_to_store #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
requested changes
Mar 22, 2022
This spec had subject and expectations somehow mixed up (at least in my mind), and it did fail occasionally. The real fix though seems to be exchanging the `eq` matchers with `match_array`, which doesn't care about order. See https://app.circleci.com/pipelines/github/solidusio/solidus/3095/workflows/16ada36d-0342-4b15-9e38-cde85df111a2/jobs/28315/tests#failed-test-0
mamhoff
force-pushed
the
fix-flaky-shipping-method-spec
branch
from
ef8b50c to
d08d961
Compare
jarednorman
approved these changes
Mar 22, 2022
|
Thanks Martin! |
tvdeyen
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec had subject and expectations somehow mixed up (at least in my
mind), and it did fail occasionally, probably because of that.
See https://app.circleci.com/pipelines/github/solidusio/solidus/3095/workflows/16ada36d-0342-4b15-9e38-cde85df111a2/jobs/28315/tests#failed-test-0
Checklist: