Update README.md chromedriver link #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
suggested changes
Mar 7, 2022
README.md
Outdated
| @@ -338,7 +338,7 @@ You can see the build statuses at | |||
|
|
|||
| #### Run all tests | |||
|
|
|||
| [ChromeDriver](https://sites.google.com/a/chromium.org/chromedriver/home) is | |||
| [ChromeDriver](https://sites.google.com/chromium.org/driver/) is | |||
There was a problem hiding this comment.
Suggested change
| [ChromeDriver](https://sites.google.com/chromium.org/driver/) is | |
| [ChromeDriver](https://chromedriver.chromium.org/downloads) is |
It seems ☝️ won't give problems, right? I just googled it 🤷♂️
|
Should we be using the webdrivers gem? |
|
Hey @Palid 👋 What do you think about the given suggestion?
We could consider that as follow-up work, yeah... 🙂 |
The link for chromedriver is leading to a deprecated website that will get remove in the nearby future. This commit updates the link to a correct version.
waiting-for-dev
approved these changes
Jun 14, 2022
|
I updated the suggestion myself. We need one more approval to get it merged cc @jarednorman @kennyadsl |
kennyadsl
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link for chromedriver is leading to a deprecated website that will get remove in the nearby future.
This commit updates the link to a correct version.
NOTE: May not work with corporate-managed google chrome account (visit in private mode instead), just google things.
Description
Checklist: