Incorrect display store credit reason #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an additional column with a width of 20% that shows the update reason (`Spree::StoreCreditReason`) for a store credit event. Size adjustments are made to the other columns to make room for this column.
The previous name ('name') is not very descriptive of this specific
column, showing the name of the `Spree::StoreCreditReason` associated
with a specific store credit event. Therefore, I made use of the
existing (but unused) locale key 'reason_for_updating' to give the
column a more descriptive name.
3 tasks
waiting-for-dev
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4264
This PR is exactly the same as #4265 but changes the name of the branch to trigger the CI.
Description
This change resolves a layout issue in store credit events table. Here the last column is used to present the name of the
Spree::StoreCreditReasonassociated with the event. However, by default the column is given no width and therefore looks cramped.In addition the column name used is not very descriptive, I've made use of an existing (but unused) locale key under
store_creditsto provide the column with a more descriptive name.See #4264 for the before image. See below for the after image.
Checklist:
I have updated Guides and README accordingly to this change (if needed)I have added tests to cover this change (if needed)