[BACKPORT] Reintroduce inverse_of: :product for variants association #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`inverse_of: :product` was moved to the `variants_including_master` association with 7c37093, but there shold be no problem in having this option specified in more than one association, in fact its removal is causing an issue and now the reference to the product changes is now lost for records in the `variants` association: p = Spree::Product.first v = p.variants.first m = p.variants_including_master.find_by(is_master: true) p.name = "Foobar" m.product.name # => "Foobar" v.product.name # => "Solidus T-Shirt"
jarednorman
approved these changes
Jan 3, 2022
waiting-for-dev
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport from master of #4227
inverse_of: :productwas moved to thevariants_including_masterassociation with 7c37093, but there should be no problem in having this option specified in more than one association, in fact its removal is causing an issue as now the reference to the product changes is lost for records in thevariantsassociation:Checklist: