Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default spree event adapter #4216

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Use default spree event adapter #4216

merged 1 commit into from
Dec 2, 2021

Conversation

peterberkenbosch
Copy link
Contributor

Description
On installing this version (currenlty unreleased) of Solidus, we
no longer support the ActiveSupport Notification adaptor, but rather
the new Spree::Event::Adapters::Default

This commit add that configuration to the spree.rb template so every
generated install is using the new defaults.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

waiting-for-dev
waiting-for-dev approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @peterberkenbosch!!

jarednorman
jarednorman approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I wouldn't mind if you fixed the defautl typo in the commit message. 😉

@peterberkenbosch
Use default Spree::Event::Adapter
d50fc68 
On installing this version (currenlty unreleased) of Solidus, we
no longer support the ActiveSupport Notification adaptor, but rather
the new `Spree::Event::Adapters::Default`

This commit add that configuration to the spree.rb template so every
generated install is using the new defaults.
@peterberkenbosch peterberkenbosch force-pushed the use-default-spree-event-adapter-on-install branch from a918343 to d50fc68 Compare December 1, 2021 17:04
@peterberkenbosch peterberkenbosch changed the title Use defautl spree event adapter Use default spree event adapter Dec 1, 2021
@peterberkenbosch
Copy link
Contributor Author

Thanks @jarednorman, fixed!

jarednorman
jarednorman approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterberkenbosch!

@waiting-for-dev waiting-for-dev merged commit 27c27d0 into solidusio:master Dec 2, 2021
@waiting-for-dev waiting-for-dev mentioned this pull request Apr 15, 2022
Merged
5 tasks
@peterberkenbosch peterberkenbosch deleted the use-default-spree-event-adapter-on-install branch August 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@waiting-for-dev waiting-for-dev waiting-for-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterberkenbosch @waiting-for-dev @spaghetticode @jarednorman