v3.1 - Use SSL on fonts.googleapis.com scss import #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 23/11/2021, `@import url(//fonts.googleapis.com/css...)` began to cause errors; Breaking Solidus and all extensions that depend on solidus_frontend. Explicitly using https protocol fixed this. Error example: https://app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572 Blocking of this URL in testing_support was updated to keep performance improvement.
RyanofWoods
changed the title
waiting-for-dev
approved these changes
Nov 25, 2021
jarednorman
approved these changes
Nov 25, 2021
|
I see there's PRs back to v2.11, but we may need to backport this to more versions. It's going to break specs across tons of extensions that support and runs specs against any older versions. 😩 |
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 23/11/2021, @import url(//fonts.googleapis.com/css...) began to
cause errors; Breaking Solidus and all extensions that depend on
solidus_frontend. Explicitly using HTTPS protocol fixed this.
Error example:
https://app.circleci.com/pipelines/github/solidusio/solidus/2791/workflows/e62ff646-9ae6-4e65-b20f-e1f7a109d3a1/jobs/26572
Blocking of this URL in testing_support was updated to keep performance
improvement.
Checklist: