Enable rubygems_mfa_required on solidus #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
requested changes
Nov 22, 2021
| @@ -14,6 +14,8 @@ Gem::Specification.new do |s| | |||
| s.homepage = 'http://solidus.io' | |||
| s.license = 'BSD-3-Clause' | |||
|
|
|||
| s.metadata['rubygems_mfa_required'] = 'true' | |||
There was a problem hiding this comment.
I think this is needed in all the other subgems as well, isn't it?
There was a problem hiding this comment.
Oh, okay, I'll update the subgems too 👍 Done.
Goal ---- As a Solidus maintainer I want to enable rubygems_mfa_required on the gem's gemspecs So that MFA will be required when performing privileged operations on the gem Reference --------- https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecrequiremfa https://guides.rubygems.org/mfa-requirement-opt-in/
gsmendoza
force-pushed
the
gsmendoza/eng-265-enable-rubygems_mfa_required-on-solidus
branch
from
d4ff977 to
36b83e3
Compare
kennyadsl
deleted the
gsmendoza/eng-265-enable-rubygems_mfa_required-on-solidus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As a Solidus maintainer
I want to enable rubygems_mfa_required on the gem's gemspec
So that MFA will be required when performing privileged operations on the gem
Reference
https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecrequiremfa
https://guides.rubygems.org/mfa-requirement-opt-in/
Checklist: