Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix polymorphic path strings v2.11 #4049

Merged
merged 2 commits into from
May 7, 2021
Merged

Fix polymorphic path strings v2.11 #4049

merged 2 commits into from
May 7, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 7, 2021 •
edited
Loading

Description

Same as #4048 but for v2.11

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

tvdeyen added 2 commits May 7, 2021 09:08
@tvdeyen
Use symbols in polymorphic path for even_links
226f895 
Rails 6.0.3.7 introduced a security fix, that forces us to use symbols
in polymorphic paths.
@tvdeyen
Use symbol for parent_model_name in resource controller
d5e2359 
Rails does not allow Strings in polymorphic urls anymore for security
reasons.
@tvdeyen tvdeyen requested a review from a team May 7, 2021 07:09
@tvdeyen tvdeyen changed the title Fix polymorphic path strings v211 Fix polymorphic path strings v2.11 May 7, 2021
spaghetticode
spaghetticode approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvdeyen !

@spaghetticode spaghetticode merged commit e16c6bd into solidusio:v2.11 May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @spaghetticode