Move "thinking cat" fixture to lib folder #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
move-file-fixtures-to-gem
branch
from
fc05857 to
8d94aa8
Compare
|
Thanks @mamhoff! 🙏 Do you think it would make more sense to move the image to |
|
Sure! but you know what: When I do that, I might as well also do the 1-pixel-image thing? I mean I don't think it's worth distributing those 20kB that I have not looked at in the however many years I've spent with this software. |
|
Go for it! 👍 |
mamhoff
force-pushed
the
move-file-fixtures-to-gem
branch
2 times, most recently
from
a059ccf to
45ad4ff
Compare
With the exclusion of the spec folder from the packaged solidus_core gem in 80bea87, all factories that use an image can now not access that image when loaded from the lib folder of a packaged gem. The reason for that is that the image referenced in those factories lives under spec/fixtures - in the spec folder. This commit does the simplest thing that could possibly work: Move the image to the lib/fixtures folder instead and adapt the factories so that they work even if loaded from the packaged gem.
This image is only 631 bytes in size, and lives in the correct location under lib/spree/testing_support in core.
|
@mamhoff thanks for this PR! For some reason, CircleCI did not receive the hook for running the CI after the last push. Can you please push again to retrigger it? |
mamhoff
force-pushed
the
move-file-fixtures-to-gem
branch
2 times, most recently
from
7818714 to
851cfec
Compare
houndci-bot
reviewed
Nov 3, 2020
We don't need a thinking cat for testing. A blank, really small image is enough.
mamhoff
force-pushed
the
move-file-fixtures-to-gem
branch
from
851cfec to
c42e3d7
Compare
This image is being replaced with a blank image that lives under core/lib/spree/testing_support.
mamhoff
force-pushed
the
move-file-fixtures-to-gem
branch
from
c42e3d7 to
ae4ed90
Compare
aldesantis
approved these changes
Nov 4, 2020
|
I'm going to backport and release Solidus 2.11.1 tomorrow, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the exclusion of the spec folder from the packaged solidus_core gem
in 80bea87, all factories that use an image can now not access that
image when loaded from the lib folder of a packaged gem.
The reason for that is that the image referenced in those factories
lives under spec/fixtures - in the spec folder.
This commit does the simplest thing that could possibly work: Move the
image to the lib/fixtures folder instead and adapt the factories so that
they work even if loaded from the packaged gem.
One could imagine a single-pixel image file instead of an actual JPEG of a thinking cat to conserve space on the many machines this gem runs on. Would that still be in scope?
I would very much like a new version of Solidus to be cut with this change, as 2.11.0 has broken factories because of this.
Checklist: