Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to stock movements page from variant stock display #3779

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add link to stock movements page from variant stock display #3779

merged 1 commit into from
Sep 29, 2020

Conversation

seand7565
Copy link
Contributor

@seand7565 seand7565 commented Sep 25, 2020 •
edited
Loading

Description
ref: #3666

Adds a link to the stock movements page from the individual variant stock displays. Because of the work already done on #3666, this page will show recent stock movements for whatever variant you clicked on.

Screen Shot 2020-09-25 at 2 56 39 PM

Screen Shot 2020-09-25 at 2 58 17 PM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

aldesantis
aldesantis approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seand7565!

@aldesantis
Copy link
Member

@seand7565 just one small thing: could you squash the commits? We generally keep the implementation and tests in the same commit. Thanks!

@seand7565
Add link to stock location name on product stock page
3125150 
Adds a link to view most recent stock movements when you click on the
stock location name in the stock items page.

Also adds a test to ensure link to stock_movements page exists from
stock_items page
@seand7565
Copy link
Contributor Author

@aldesantis Sure thing, done!

@aldesantis aldesantis requested a review from a team September 29, 2020 13:23
kennyadsl
kennyadsl approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean!

@kennyadsl kennyadsl merged commit be7c78e into solidusio:master Sep 29, 2020
@kennyadsl kennyadsl added type:enhancement Proposed or newly added feature changelog:solidus_backend Changes to the solidus_backend gem UI and removed Needs Core Team Review labels Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seand7565 @aldesantis @kennyadsl