Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint to tax category default checkbox #3778

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add hint to tax category default checkbox #3778

merged 1 commit into from
Sep 30, 2020

Conversation

pelargir
Copy link
Contributor

@pelargir pelargir commented Sep 25, 2020 •
edited
Loading

Description

This adds a hint to the default checkbox on the tax category form.

Screen Shot 2020-09-25 at 2 29 53 PM

Ref: #3774

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@peterberkenbosch
Copy link
Contributor

Thanks @pelargir! :shipit: from me!

kennyadsl
kennyadsl approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pelargir!

@kennyadsl kennyadsl merged commit f7c258d into solidusio:master Sep 30, 2020
@kennyadsl kennyadsl added changelog:solidus_backend Changes to the solidus_backend gem UI labels Sep 30, 2020
@tvdeyen tvdeyen deleted the add-tax-category-default-checkbox-hint branch December 11, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pelargir @peterberkenbosch @kennyadsl @aldesantis