Refactor Product#available? to match docs #3733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a very small quality-of-life type improvement, but I noticed that the safe navigation operator can be used to simplify the logic of the
Product#available?
method.Rephrasing the logic this way we:
deleted
andavailable_on
conditions, to better match the docs, which say,A product is available if it has not been deleted and the available_on date is in the past.
It’s not earth shattering by any means, but it makes the code that much more readable IMO, especially for folks new to Solidus.