Removes deprecated usage of associate_user on OrdersController #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
Needs Work
changelog:solidus_core
5 tasks
|
This was closed due to the opening of another one: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request solves the issue #3559
Based on this discussion this
associate_usercall is deprecated due to changes during the creation or building of an order viacurrent_orderwhere before the creation and association of an user were made in different places now it is done immediately. This seems to classify as refactoring, and for that reason I didn't add testsThere is also a call of
associate_userinCheckoutControllerwhich is called afterload_orderthat callscurrent_orderbut I didn't remove it here due to the discussion regarding the order of execution and its impacts on some stores. I would like @elia's comment regarding this, and maybe we could do it on this PR as well.Checklist: