2777 inactive actionless promotions #3596
Conversation
wildbillcat
force-pushed
the
2777-inactive-actionless-promotions
branch
3 times, most recently
from
c42a852 to
df21004
Compare
core/lib/spree/app_configuration.rb
Outdated
| @@ -202,6 +202,10 @@ class AppConfiguration < Preferences::Configuration | |||
| # @return [Integer] Promotions to show per-page in the admin (default: +15+) | |||
| preference :promotions_per_page, :integer, default: 15 | |||
|
|
|||
| # @!attribute [rw] disable_actionless_promotion_validation | |||
| # @return [Boolean] Promotions should have actions associated before activation (default: +true+) | |||
| preference :actionless_promotion_inactive, :boolean, default: true | |||
There was a problem hiding this comment.
I haven't really reviewed the PR yet but in the meantime, I think this should be changed. The default value should be the one that represents the old behavior (false in this case). This way, users that upgrade Solidus will keep having the same behavior and will see a deprecation warning. They will have the chance to take a look at what happens before switching the value.
New Solidus users will have the new version of spree.rb initializer instead and they will start their apps with the new default.
How does it sound?
There was a problem hiding this comment.
No worries and sounds fine. This will probably take me a little while as the change of function appears to break a lot of tests, so I need to reconcile the change across functions.
|
@wildbillcat I'd love to get this into 2.11, which will be the last release in the 2.x branch. That way, we can completely remove the old behavior in 3.0. Let me know if you think it's doable! |
|
No Idea haha. But holiday weekend, so I'll see if I can sort out the issues this weekend. |
|
@aldesantis Apologies, had some work stuff come up over the weekend that kept me from working on this. I'll pick this up this evening and try to have an update for you Friday. Cheers, |
…no actions are assigned
wildbillcat
force-pushed
the
2777-inactive-actionless-promotions
branch
from
db12407 to
527b8dd
Compare
|
Closing in favor of #3749, thanks! |
Description
This is a proposed solution to #2777 where action-less promotions were considered active. As opposed to my original thought of implementing validation, given that there is no state toggle on the promotion that it would make sense to embrace the inferred state. So this implementation just causes a promotion to be considered inactive until it has actions, in addition to the other required material. Otherwise it is considered inactive.
In the process I found the coupon promotion handler already treated action-less coupons as inactive, so I updated it to continue this behavior.
Checklist: