Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move API documentation to solidus_api #3323

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Move API documentation to solidus_api #3323

merged 1 commit into from
Sep 3, 2019

Conversation

aldesantis
Copy link
Member

Description

This makes sense since the API is provided by the solidus_api gem and will avoid confusion when we'll also have GraphQL support.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@aldesantis aldesantis mentioned this pull request Sep 2, 2019
Merged
4 tasks
kennyadsl
kennyadsl approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense, thanks @aldesantis.

jacobherrington
jacobherrington approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aldesantis!

@kennyadsl kennyadsl merged commit 0ebe0c8 into solidusio:master Sep 3, 2019
@aldesantis aldesantis deleted the chore/move-api-docs branch September 3, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldesantis @kennyadsl @jacobherrington