Explicitly require Bundler within Rakefile #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
👍 Thanks @mdesantis , this is needed since we use Bundler directly in the Rakefile.
mdesantis
force-pushed
the
mdesantis/3021/bundler-2-compatibility
branch
from
fb5345e to
942ec5c
Compare
Closes solidusio#3021. It fixes an error related to the Rakefile, where rake tasks which use `Bundler` constant, such as `rake sandbox`, fail if `bundler` is not explicitly required.
|
@mdesantis was this closed by accident? |
|
Yes, I'm sorry, I made a mistake while editing the commit message removing the Bundler version part, which happens to be unrelated |
jacobherrington
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3021. It fixes an error related to the Rakefile, where rake
tasks which use
Bundlerconstant, such asrake sandbox, fail ifbundleris not explicitly required.