Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bcc fields to stores #2905

Closed
wants to merge 2 commits into from
Closed

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Oct 8, 2018

This PR adds the possibility to specify BCC email addresses for the confirmation order emails in the Store admin tab.

@afdev82 afdev82 force-pushed the add_bcc_addresses branch from 3668180 to 8b53a44 Compare October 8, 2018 11:35
@kennyadsl
Copy link
Member

Why bcc should only apply to the order confirm email?

@afdev82
Copy link
Contributor Author

afdev82 commented Oct 8, 2018

Because I needed only for that... But once we have this field we could use it also for other methods that send emails.
In my case the need was to have only the confirmation order emails in BCC to other email addresses.

@kennyadsl
Copy link
Member

I think that we need to provide a way to let devs choose which emails they want to add bcc into if we want to introduce this feature.
Other users could need to add it to shipment confirmation emails also for example and if they need to override code to make that happen I think this is not worth the change since they could just change code to add the bcc to the order confirm email as well.

IMO if we don't go in this direction it's better to keep this customization out of core, maybe an extension or directly into apps.

@afdev82
Copy link
Contributor Author

afdev82 commented Oct 8, 2018

What you say it makes sense.
I just thought that the functionality to receive an email when an order is performed instead of having to log in in the website and check there, was pretty common and nothing stops to add the same functionality for other emails too.
I wanted only to reduce the need to override views / methods in my app just to add the bcc field to the emails, because it's always a problem with upgrades.
If it's worth to have in the core or in an extension, I don't know.

@ericsaupe
Copy link
Contributor

I agree with @kennyadsl, I think there is value in having BCC fields for stores but I'd like to see this solution expanded to include the possibility of having BCCs on all emails sent. It might be a good idea to have this start as an extension and then reopen with a full solution into core once it's been fully implemented.

@kennyadsl
Copy link
Member

Closing this, let us know if you build the extension and thanks again for contributing!

@kennyadsl kennyadsl closed this Oct 18, 2018
@afdev82
Copy link
Contributor Author

afdev82 commented Oct 19, 2018

Ok 👍

@afdev82 afdev82 deleted the add_bcc_addresses branch October 16, 2020 10:21
@afdev82 afdev82 mentioned this pull request Oct 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants