Remove .travis.yml #2876
Merged
Remove .travis.yml #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobherrington
changed the title
jacobherrington
force-pushed
the
patch-5
branch
from
53e495c to
25a65f2
Compare
tvdeyen
requested changes
Sep 27, 2018
|
|
|
@tvdeyen in that case can we remove |
|
That's a good idea
|
|
Added a commit, should I make a new PR or use this one? |
jacobherrington
changed the title
ericsaupe
suggested changes
Sep 27, 2018
We aren't testing with TravisCI, so this file is just confusing.
jacobherrington
force-pushed
the
patch-5
branch
from
910668f to
9659bc6
Compare
|
@ericsaupe good call. done! |
ericsaupe
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to not require Ruby 2.3, so we should
make sure we are aware of any issues on Ruby 2.2
and Ruby 2.5.1 once broke Solidus, so it seems smart
to test against it as well.
Creating this PR to test CI and facilitate discussion.
Related:
#2794
#2825