Move API pagination into a common partial #2181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pagination was handled individually by each index partial, which led to some inconsistencies.
This PR adds a
spree/api/shared/pagination.json.jbuilder
partial which is passed a paginated collection and renders the pagination attributes.This doesn't change any existing attributes, but some endpoints will now have
per_page
andtotal_count
, which were missing previously.