Exclude Bootstrap buttons from our button styling #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately we cannot currently use the Bootstrap classes on button or input elements. This change allows us to do that by adding another `:not()` selector to our custom button styles. We want to keep the `@extend` so that our extensions and other legacy content continue to have appropriately styled buttons. Unfortunatley we cannot simply add `:not(.btn)` because we then `@extend .btn` and Sass very quickly gets confused as to what we're asking it to do. Therefor we need to use `:not([class*="btn"])` to essentially trick Sass into ignoring our rather unique use case.
jhawthorn
approved these changes
Aug 16, 2017
tvdeyen
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we cannot currently use the Bootstrap classes on button or
input elements. This change allows us to do that by adding another
:not()selector to our custom button styles.We want to keep the
@extendso that our extensions and other legacycontent continue to have appropriately styled buttons.
Unfortunatley we cannot simply add
:not(.btn)because we then@extend .btnand Sass very quickly gets confused as to what we'reasking it to do. Therefor we need to use
:not([class*="btn"])toessentially trick Sass into ignoring our rather unique use case.