Remove is_default Boolean from prices (rebased) #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
remove-is-default-boolean-from-prices
branch
from
e657822 to
5d5a158
Compare
|
Seems reasonable but the specs are unhappy. |
mamhoff
force-pushed
the
remove-is-default-boolean-from-prices
branch
from
5d5a158 to
4dcc0a2
Compare
This boolean is either a very bare-bones version of `acts_as_paranoid` or a very bare-bones version of `papertrail`. However: It's really badly named, as `is_default` is not something I understand very well at all. We can accomplish the same behavior by simply using an `order` clause in the `currently_valid` scope on prices.
mamhoff
force-pushed
the
remove-is-default-boolean-from-prices
branch
from
4dcc0a2 to
b2eed20
Compare
gmacdougall
approved these changes
Sep 26, 2016
|
👍 |
jordan-brough
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boolean is either a very bare-bones version of
acts_as_paranoidora very bare-bones version of
papertrail. However: It's really badly named,as
is_defaultis not something I understand very well at all. It probably means"the price to be used in the backend and mostly in the frontend too".
We can accomplish the same behavior by simply using an
orderclause inthe
currently_validscope on prices.This PR is #1182 rebased.