Fix incorrect payment total calculation in process_payments_with #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
|
👍 |
1 similar comment
|
👍 |
In 11de63f we added the inverse_of relation between order and payments, which caused some issues in process_payments_with from Order::Payments. Payment has an after_save which triggers an order.update!, which updates the payment_total. process_payments_with was doing self.payment_total += payment.amount on each successful payment, making each payment amount counted twice. This removes the addition in process_payments_with and relies on the callback performing the order update (which will update the payment total properly). This commit also removes stubbing from a specs which now exposes this issue.
jhawthorn
force-pushed
the
payment_total_inverse_of_issue
branch
from
6cee93d to
196ea27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 11de63f we added the inverse_of relation between order and payments, which caused some issues in
process_payments_withfromOrder::Payments.Payment has an
after_savewhich triggers anorder.update!, which updates the payment_total. process_payments_with was doingself.payment_total += payment.amounton each successful payment, making each payment amount counted twice.This removes the addition in
process_payments_withand relies on the callback performing the order update (which will update the payment total properly).This commit also removes stubbing from a specs which now exposes this issue.