Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated scope in StoreCreditReason #3628

Closed
halilim opened this issue May 20, 2020 · 1 comment · Fixed by #3629
Closed

Duplicated scope in StoreCreditReason #3628

halilim opened this issue May 20, 2020 · 1 comment · Fixed by #3629

Comments

@halilim
Copy link

halilim commented May 20, 2020

StoreCreditReason & NamedType both have the scope active with the same definition. This logs a warning:

Creating scope :active. Overwriting existing method Spree::StoreCreditReason.active.
halilim pushed a commit to halilim/solidus that referenced this issue May 20, 2020
Remove the duplicated active scope
5207d23 
It's already defined in `Spree::NamedType`. Fixes solidusio#3628.
@halilim halilim mentioned this issue May 20, 2020
Merged
5 tasks
@peterberkenbosch
Copy link
Contributor

Good find! Thanks @halilim

mamhoff pushed a commit to mamhoff/solidus that referenced this issue Feb 1, 2021
@mamhoff
Remove the duplicated active scope
333d1e6 
It's already defined in `Spree::NamedType`. Fixes solidusio#3628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the duplicated active scope and name validations halilim/solidus
2 participants
@peterberkenbosch @halilim