Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order state does not change after a customer return is received #3198

Closed
spaghetticode opened this issue May 3, 2019 · 2 comments
Closed

Comments

@spaghetticode
Copy link
Member

When an order has more than one line item, creating a return for all the items at once and setting the reception status to Received fails to change the order state to Returned, like it does with orders with one single line item. See attached screenshot.

Solidus Version:

master

Screenshots

Schermata 2019-05-03 alle 17 22 38

spaghetticode added a commit to nebulab/solidus that referenced this issue May 10, 2019
…! callback

Processing order returns in `ReturnItem#process_inventory_unit!` does not work
reliably when there are multiple return items processed at the same time (see
issue solidusio#3198).

Also, decoupling sensible interactions with other models in ActiveRecord
callbacks simplifies the understandability of code and its flow.

Order processing in `#process_inventory_unit!` is now only deprecated, but will
be completely removed in the following release of Solidus.
spaghetticode added a commit to nebulab/solidus that referenced this issue May 15, 2019
…! callback

Processing order returns in `ReturnItem#process_inventory_unit!` does not work
reliably when there are multiple return items processed at the same time (see
issue solidusio#3198).

Also, decoupling sensible interactions with other models in ActiveRecord
callbacks simplifies the understandability of code and its flow.

Order processing in `#process_inventory_unit!` is now only deprecated, but will
be completely removed in the following release of Solidus.
@jacobherrington
Copy link
Contributor

@spaghetticode Can this issue be closed after #3199?

@spaghetticode
Copy link
Member Author

@jacobherrington sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants