deprecate unused link_to_remove_fields helper function and ".spree_re…

…move_fields" click event
solidusio · Apr 21, 2020 · ec84339 · ec84339
1 parent 5284611
commit ec84339
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 25 deletions.
diff --git a/backend/app/assets/javascripts/spree/backend/admin.js b/backend/app/assets/javascripts/spree/backend/admin.js
@@ -99,31 +99,6 @@ Spree.ready(function(){
     return false;
   });
 
-  $('body').on('click', 'a.spree_remove_fields', function() {
-    var el = $(this);
-    el.prev("input[type=hidden]").val("1");
-    el.closest(".fields").hide();
-    if (el.prop("href").substr(-1) == '#') {
-      el.parents("tr").fadeOut('hide');
-    }else if (el.prop("href")) {
-      Spree.ajax({
-        type: 'POST',
-        url: el.prop("href"),
-        data: {
-          _method: 'delete',
-        },
-        success: function(response) {
-          el.parents("tr").fadeOut('hide');
-        },
-        error: function(response, textStatus, errorThrown) {
-          show_flash('error', response.responseText);
-        }
-
-      })
-    }
-    return false;
-  });
-
   window.Spree.advanceOrder = function() {
     Spree.ajax({
       type: "PUT",

diff --git a/backend/app/helpers/spree/admin/base_helper.rb b/backend/app/helpers/spree/admin/base_helper.rb
@@ -132,6 +132,8 @@ def link_to_remove_fields(name, form, options = {})
         link_to_with_icon('trash', name, url, class: "spree_remove_fields #{options[:class]}", data: { action: 'remove' }, title: t('spree.actions.remove')) +
           form.hidden_field(:_destroy)
       end
+      deprecate link_to_remove_fields: "Please use link_to_delete instead, Example: \n" \
+        "link_to_delete \"form.object\", deprecator: Spree::Deprecation
 
       def spree_dom_id(record)
         dom_id(record, 'spree')