Merge pull request #5059 from nebulab/kennyadsl/remove-factories-left…

…over Deprecate other code related to old factories loading
solidusio · Apr 28, 2023 · daf1b10 · daf1b10
2 parents afa58b4 + bf5b7aa
commit daf1b10
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/core/lib/spree/testing_support.rb b/core/lib/spree/testing_support.rb
@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
 require 'spree/testing_support/factory_bot'
+require 'spree/deprecation'
+
+Spree::Deprecation.warn <<-WARN
+  Using `require 'spree/testing_support'` is deprecated and will be removed in
+  Solidus 4.0.
+WARN
 
 module Spree
   module TestingSupport
@@ -11,5 +17,6 @@ module TestingSupport
     def check_factory_bot_version
       Spree::TestingSupport::FactoryBot.check_version
     end
+    deprecate :check_factory_bot_version, deprecator: Spree::Deprecation
   end
 end
diff --git a/core/lib/spree/testing_support/factory_bot.rb b/core/lib/spree/testing_support/factory_bot.rb
@@ -30,6 +30,7 @@ def self.check_version
           MSG
         end
       end
+      deprecate :check_version, deprecator: Spree::Deprecation
 
       def self.add_definitions!
         ::FactoryBot.definition_file_paths.unshift(*definition_file_paths).uniq!
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,6 +30,7 @@ def self.check_version @@
               MSG
             end
           end
+          deprecate :check_version, deprecator: Spree::Deprecation
           def self.add_definitions!
             ::FactoryBot.definition_file_paths.unshift(*definition_file_paths).uniq!
@@ Expand Down @@