Move Permalinks include to ApplicationRecord

Monkey patching directly ActiveRecord::Base is dangerous and discouraged.
solidusio · Jan 10, 2020 · 1f824bb · 1f824bb
1 parent 896bcb7
commit 1f824bb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/app/models/spree/application_record.rb b/core/app/models/spree/application_record.rb
@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
 class Spree::ApplicationRecord < ActiveRecord::Base
+  include Spree::Core::Permalinks
+
   self.abstract_class = true
 end
diff --git a/core/lib/spree/core/permalinks.rb b/core/lib/spree/core/permalinks.rb
@@ -63,5 +63,3 @@ def save_permalink(permalink_value = to_param)
     end
   end
 end
-
-ActiveRecord::Base.send :include, Spree::Core::Permalinks
-Original file line number
+Diff line change
@@ Expand Up / @@ -63,5 +63,3 @@ def save_permalink(permalink_value = to_param) @@
         end
       end
     end
-    ActiveRecord::Base.send :include, Spree::Core::Permalinks