This repository has been archived by the owner on Oct 23, 2019. It is now read-only.
Fix factory girl dependency for Solidus < 2.5 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to load a factory_bot version that has factory_girl in it to support Solidus versions < 2.5 This change also includes conditional logic for the database interface gems.
|
@kennyadsl I'd like to make this change on more extensions. Are we alright with this solution for testing extensions? It seems to work pretty well. |
|
Sure, I've gently requested to all Nebulab devs to contribute on this so maybe we should coordinate someway? |
|
@kennyadsl I'll start from the bottom of http://extensions.solidus.io/ 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to load a factory_bot version that has factory_girl in it
to support Solidus versions < 2.5
This change also includes conditional logic for the database
interface gems.