Add feedback reviews to api #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 7, 2020 08:41
dependent was set on the belongs_to association for feedback_reviews to destroy the review it belonged to. This would mean that if an individual wanted to remove feedback, it would also remove the review it was attached to. Seems pretty weird. I moved the dependent: :destroy declaration to the Review model, so that if a review is removed, it will remove all attached feedback.
Tests have been written for the api feedback_reviews controller. This covers creating a feedback_review and only allowing one feedback_review per user per review. The update and destroy actions are tested against other users attempting to perform these actions on other instances. The update and destroy actions have been added to CanCan ability. So that users can update their own reviews without needing to be admin.
ericsaupe
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds feedback_reviews create, update, and destroy actions to respond to JSON requests.
New roles have been added for users to update and destroy their feedback_reviews.