Fix path for Spree::ProductsControllerDecorator #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
force-pushed
the
bugfix/decorator-namespacing
branch
2 times, most recently
from
e60768f to
f652da4
Compare
aldesantis
changed the title
aldesantis
force-pushed
the
bugfix/decorator-namespacing
branch
from
f652da4 to
642d41a
Compare
There is no reason for avg_rating or reviews_count to be writeable, especially by regular users, since they are computed values.
aldesantis
force-pushed
the
bugfix/decorator-namespacing
branch
from
642d41a to
b6aef6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77 by changing the path of
Spree::ProductsControllerDecorator.Also removes some permitted attributes from
Spree::ProductsControllerthat were not really needed.