This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
Remove address from shipment in order_factory override #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solidus PR1138 deprecated the address field in the shipment model, the edited factory was still using this field, causing errors.
|
For versions before master, the field is still there (but it's not used so no harm in removing it) What do you think Chris? |
|
@dangerdogz This looks good to me, we shouldn't be assigning address on shipment anyways so this is a good change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidus PR#1138 deprecated the address field in the shipment model, the edited factory was still using this field, causing test failures everywhere.