Make config param private in the PackageBuilder

solidusio-contrib · Jun 28, 2016 · dfa4673 · dfa4673
1 parent c32e9f7
commit dfa4673
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/app/models/spree/package_builder.rb b/app/models/spree/package_builder.rb
@@ -8,6 +8,8 @@ def process(solidus_package, max_weight)
       to_packages(solidus_package)
     end
 
+    private
+
     # Configuration 
     def units
       Spree::ActiveShipping::Config[:units].to_sym
@@ -21,8 +23,6 @@ def default_weight
       Spree::ActiveShipping::Config[:default_weight]
     end
 
-    private
-
     def convert_package_to_weights_array(product_with_product_packages)
       weights = product_with_product_packages.map do |content_item|
         item_weight = content_item.weight

diff --git a/spec/models/package_builder_spec.rb b/spec/models/package_builder_spec.rb
@@ -15,18 +15,6 @@
     allow(package_builder).to receive(:multiplier).and_return(1)
   end
 
-  it 'has a a unit_multiplier value' do
-    expect(package_builder.multiplier).not_to be_nil
-  end
-
-  it 'has a a units value' do
-    expect(package_builder.units).not_to be_nil
-  end
-
-  it 'has a a default_weight value' do
-    expect(package_builder.default_weight).not_to be_nil
-  end
-
   describe 'process' do
     include_context 'package setup'