Fix Solid Start #154
Merged
Fix Solid Start #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f868715 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yume-chan
force-pushed
the
fix/solid-start
branch
from
3228599 to
f868715
Compare
|
Thank you I will look at this. We looked to 2.9 for a different reason which I thought I had fixed. And just hadn't gotten around to 2.10 again. |
|
Actually new SolidStart is fine it appears. But no harm in merging this as well. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I accidently upgraded
vite-plugin-solidto 2.10.2 in my Solid Start (0.3.x) project, and got thatReact is not definederror (#103 (comment))I like the RegExp trick to test all 6 file extensions at once, but it didn't consider the query part in
id, thus skipping transforming Solid Start files.I guess Solid Start 0.7.x branch also needs this fix, because it still pins
vite-plugin-solidat~2.9.1.