encode api url components (#1604)

* encode api url components * Create thin-swans-yell.md --------- Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
solidjs · Aug 21, 2024 · 7ae221b · 7ae221b
1 parent 516eb82
commit 7ae221b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/thin-swans-yell.md b/.changeset/thin-swans-yell.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+encode api url components
diff --git a/packages/start/src/router/routes.ts b/packages/start/src/router/routes.ts
@@ -73,7 +73,7 @@ function containsHTTP(route: Route) {
 const router = createRouter({
   routes: (fileRoutes as unknown as Route[]).reduce((memo, route) => {
     if (!containsHTTP(route)) return memo;
-    let path = route.path.replace(/\/\([^)/]+\)/g, "").replace(/\([^)/]+\)/g, "").replace(/\*([^/]*)/g, (_, m) => `**:${m}`);
+    let path = route.path.replace(/\/\([^)/]+\)/g, "").replace(/\([^)/]+\)/g, "").replace(/\*([^/]*)/g, (_, m) => `**:${m}`).split('/').map(s => (s.startsWith(':') || s.startsWith('*')) ? s : encodeURIComponent(s)).join('/');
     if (/:[^/]*\?/g.test(path)) {
       throw new Error(`Optional parameters are not supported in API routes: ${path}`);
     }