Skip to content

Commit

Permalink
fix: sd-select default scrollbar (#1769)
Browse files Browse the repository at this point in the history
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1318

This PR addresses:
- sd-select default scrollbar appearing by default, even when unecessary

## Definition of Reviewable:
- [x] relevant tickets are linked
  • Loading branch information
paulovareiro29 authored Jan 15, 2025
1 parent 38581d8 commit 49615f2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/hip-impalas-cheat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solid-design-system/docs': patch
---

Fix `sd-select` displaying the scrollbar by default, even when unecessary.
2 changes: 1 addition & 1 deletion packages/components/src/components/select/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ export default class SdSelect extends SolidElement implements SolidFormControl {
aria-labelledby="label"
part="listbox"
class=${cx(
'bg-white px-2 py-3 relative border-primary overflow-y-scroll',
'bg-white px-2 py-3 relative border-primary overflow-y-auto',
this.open && 'shadow',
this.currentPlacement === 'bottom'
? 'border-r-2 border-b-2 border-l-2 rounded-br-default rounded-bl-default'
Expand Down

0 comments on commit 49615f2

Please sign in to comment.