Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require write on container for DELETE #42

Closed
michielbdejong opened this issue Nov 1, 2021 · 1 comment
Closed

Require write on container for DELETE #42

michielbdejong opened this issue Nov 1, 2021 · 1 comment

Comments

@michielbdejong
Copy link
Collaborator

See https://gitter.im/solid/test-suite?at=617fd9a9fb3dcd4e885f2ab5

Kjetil Kjernsmo @kjetilk 13:12
I found that NSS isn't checking write on the container for deletes, which is in the draft spec.
Just wondering what you're checking in the test-suite, is it checked there?

and

Michiel de Jong @michielbdejong 14:15
Hm, odd. That indeed seems to be what
https://github.com/solid/web-access-control-tests/blob/main/test/surface/delete.test.ts
is checking, and indeed it doesn't make sense.
if PUT-to-create and PATCH-to-create require write access on the container to create the
containment triple, then DELETE should also require write access on the container to remove it.

@michielbdejong
Copy link
Collaborator Author

As expected (see #41), this increases the number of WAC test failures for CSS v2.0.1 from 6 to 7:
● Create › Using PUT in existing container › is disallowed without accessTo Write or Append
● Create › Using PATCH in existing container › is disallowed without default Write
● Create › Using PATCH in existing container › is disallowed without accessTo Write or Append
● Create › Using PUT in non-existing container › is disallowed without accessTo Write or Append
● Create › Using PATCH in non-existing container › is disallowed without default Write
● Create › Using PATCH in non-existing container › is disallowed without accessTo Write or Append
● Delete › Is disallowed without Write on parent

michielbdejong added a commit that referenced this issue Nov 23, 2021
Require Write on parent and resource for DELETE, fix #42
michielbdejong added a commit to pdsinterop/php-solid-auth that referenced this issue Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant