Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/fix load trait props script #4703

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Topic/fix load trait props script #4703

merged 13 commits into from
Oct 20, 2023

Conversation

lukasmueller
Copy link
Member

Description

make sure that trait minimum and maximum values are loaded for values of zero, not for values of empty string.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

darekbienkowski
darekbienkowski approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@darekbienkowski darekbienkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit a39357d into master Oct 20, 2023
@lukasmueller lukasmueller deleted the topic/fix_load_trait_props_script branch October 20, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darekbienkowski darekbienkowski darekbienkowski approved these changes

@isaak isaak isaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasmueller @isaak @darekbienkowski