Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/solgs/fix genetic gain #4696

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Topic/solgs/fix genetic gain #4696

merged 3 commits into from
Oct 20, 2023

Conversation

isaak
Copy link
Member

@isaak isaak commented Oct 13, 2023 •
edited
Loading

Description

-- fix genetic gain boxplotting in single trait prediction page
-- convert geneticGain controller to a REST controller
-- add selenium test for for genetic gain boxplotting

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@isaak isaak requested review from nmenda and chris263 October 13, 2023 09:02
chris263
chris263 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@chris263 chris263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@darekbienkowski darekbienkowski self-requested a review October 16, 2023 15:07
darekbienkowski
darekbienkowski approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@darekbienkowski darekbienkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@lukasmueller lukasmueller merged commit 60c6543 into master Oct 20, 2023
1 check passed
@lukasmueller lukasmueller deleted the topic/solgs/fix-genetic-gain branch October 20, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 chris263 approved these changes

@darekbienkowski darekbienkowski darekbienkowski approved these changes

@nmenda nmenda Awaiting requested review from nmenda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaak @darekbienkowski @chris263 @lukasmueller