Topic/audit tables patch

[afpowell]

Description

Closes #4237

Checklist

• Refactoring only
• Documentation only
• Fixture update only
• Bug fix
  • The relevant issue has been closed.
  • Further work is required.
• New feature
  • Relevant tests have been created and run.
  • Data was added to the fixture
    • Data was added via a patch in /t/data/fixture/patches/.
  • User-Facing Change
    • The user manual in /docs has been updated.
  • Any new Perl has been documented using perldoc.
  • Any new JavaScript has been documented using JSDoc.
  • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

[afpowell]

From my testing, these seem to be the unaltered audit tables:

cvterm_dbxref_audit
cvtermprop_audit
cvtermsynonym_audit
dbxrefprop_audit
nd_experiment_contact_audit
nd_experiment_dbxref_audit
nd_experiment_pub_audit
nd_experiment_stock_dbxref_audit
nd_experiment_stockprop_audit
nd_protocol_reagent_audit
nd_reagent_audit
nd_reagentprop_audit
nd_reagent_relationship_audit
organism_dbxref_audit
organismpath_audit
organismprop_audit
organism_relationship_audit
phenotype_cvterm_audit
phenotypeprop_audit
project_contact_audit
project_pub_audit
pubabstract_audit
pub_audit
pubauthor_audit
pub_dbxref_audit
pubprop_audit
pub_relationship_audit
sp_organization_audit
stockcollection_audit
stockcollectionprop_audit
stockcollection_stock_audit
stock_cvterm_audit
stock_cvtermprop_audit
stock_dbxref_audit
stock_dbxrefprop_audit
stock_genotype_audit
stockprop_pub_audit
stock_pub_audit

[darekbienkowski]

I checked most of the audit tables through unit fixtures, selenium, and some bases of the normal interface.
Patch works correctly.
Tables for operation INSTER, UPDATE and DELETE works correctly.
Some audit tables are interesting - for example, creating a list from wizard cerates 3 events in audit tables - but it is because of how controller works in code to create a table - not an audit table.
;-)

[chris263]

+1:

[lukasmueller]

Note from the labmeeting today: phenotype upload showed spinning wheel on this branch with a error containing phenotype file (did not show an error message). This may not be specific to this branch though... will test more.

[lukasmueller]

The upload issue could be a docker config issue on cassava-devel